On Fri, 2017-04-28 at 01:22 +0800, b91502...@ntu.edu.tw wrote: > Sorry that recently I have no much spare time to work at it. I know > this > tool still needs some improvements before it can be officially > released.
No worries, same here :) > ---------- > From: Michael Natterer > Sent: Saturday, April 22, 2017 9:55 AM > To: b91502...@ntu.edu.tw ; gimp-developer-list@gnome.org > Subject: Re: [Gimp-developer] Enhanced smudge tool : Smudge with > painting > > > - gimp_gegl_smudge_blend() and its parameters were renamed > > for (imo) no good reason > > - variables should be declared at the start of a block > > - we don't use c++ comments > > About the first one, gimp_gegl_smudge_with_paint() is not a renaming, > but a > new function with different algorithm. The old one, > gimp_gegl_smudge_blend(), was removed since only smudge tool used it. > I used the same variable name with gimp_smudge_motion() for easier to > read. You are right, the renaming makes sense, let's keep it. > And the other two, I have changed yet. I would try to implement color > from > gradient and color brush later, and update both changes together. Great, looking forward to it! One more thing: can we credit you (log and AUTHORS) with a real name, or do you prefer to stay anonymous (which is perfectly fine too)? Thanks, Mitch _______________________________________________ gimp-developer-list mailing list List address: gimp-developer-list@gnome.org List membership: https://mail.gnome.org/mailman/listinfo/gimp-developer-list List archives: https://mail.gnome.org/archives/gimp-developer-list
