Zbigniew Chyla <[EMAIL PROTECTED]> writes:

> Currently GIMP crashes in some situations (for example, when scaling an
> image) if it's compiled with G_DISABLE_ASSERT macro defined. 

Most lines of your patch only affect stuff that is broken if 
G_DISABLE_CHECKS is defined (which happens very rarely). But you are
correct that assigning variables inside those macros is a bad habit.

> Attached patch fixes this. 

It would have been nice if you had inserted the patch which would have 
made it easier to comment it in a reply.

> Is it ok to commit? (the patch is against gimp-1-2 branch)

Yes, please. Would be nice if you could also merge the changes into the
HEAD branch. 

Salut, Sven
Gimp-developer mailing list

Reply via email to