David Necas (Yeti) <[EMAIL PROTECTED]> writes:

> I've fixed a few things (mostly porting problesm) in GFlare.

could you please file a bug-report at bugs.gimp.org and attach your
patch to that report? (You need to first create the report before you
can attach files.)

> 3. Circle/polygon radio button didn't work. This is
> a general Gtk2 porting issue. ANY plugin using
> gtk_object_set_user_data() is probably broken.

why would that be? Of course we discourage the use of
gtk_object_set_user_data() since it's deprecated but it still works
nevertheless. You are however right that it doesn't work here since
we changed the functions in libgimpwidgets that used to use the
data attached with gtk_object_set_user_data().

> +  //gtk_object_set_user_data (GTK_OBJECT (toggle), (gpointer) GF_CIRCLE);
this is forbidden in GIMP code since it's not portable. Please use
C-style comments.

> 4. It set polygon entry width to 8 pixels using some
> deprecated function. It's maybe a little too wide w/o it,
> but that's much better than unusably thin.
> --- gflare.orig/gflare.c      2002-09-06 22:44:43.000000000 +0200
> +++ gflare/gflare.c   2002-11-05 18:50:16.000000000 +0100
> @@ -4148,7 +4151,7 @@
>    gtk_widget_show (toggle);
>    entry = ed->polygon_entry = gtk_entry_new ();
> -  gtk_widget_set_usize (entry, ENTRY_WIDTH, 0);
> +//  gtk_widget_set_usize (entry, ENTRY_WIDTH, 0);
>    g_snprintf (buf, sizeof (buf), "%d", gflare->sflare_nverts);
>    gtk_entry_set_text (GTK_ENTRY (entry), buf);
>    gtk_signal_connect (GTK_OBJECT (entry), "changed",

again, the C++ style comment is not acceptable here. Either remove
the line or set the entry to a reasonable number of chars using

Salut, Sven
Gimp-developer mailing list

Reply via email to