On Thu, 2006-08-10 at 10:04 -0400, Kevin Sookocheff wrote:
> Hello everyone,
> I recently finished an implementation of the healing brush.  A patch
> implementing the brush is given at
> http://bugzilla.gnome.org/show_bug.cgi?id=109801#c11 but does not
> contain the icon and cursor that I created for the tool.
> I have also posted some screen shots of the results of the tool at:
> http://picasaweb.google.com/kevin.sookocheff/HealingBrushExamples
> I just tried the brush on some example images I found on the web.

This looks great!

> (1) Allow the source healing point to be taken from a separate image.
> I tried implementing this by referencing the clone tool
> implementation, but got stuck on it.  At this point I want to get the
> tool into CVS and get some feedback, so I'll work on this
> incrementally from here. 

Shouldn't the healing tool be derived from GimpCloneTool? It seems to be
similar enough. Perhaps you need to add a virtual function or two to the
clone tool. But then it should be possible to share most of the code by
deriving from it.

> (2) The brush does not work for indexed images.  I'm not sure how to
> fix this, but I haven't given it too much thought at this point.

Quite a few tools don't work for indexed images (color correction
tools). This is not a problem. Nice if it can be avoided but tolerable.

> (3) Further integration as a GIMP tool.  There are a lot of points in
> the code where the new tool should be integrated ( i.e.,
> app/gimpcore.def).

What are the other points where it would need to be integrated.
app/gimpcore.def is nothing you would have to worry about. It is
maintained by Hans Breuer and if he needs it to be updated, he will do
that for you.

> So, I'd like to get this tool checked into CVS, but first I'm asking
> permission to do that :)  I have commit access to CVS so if someone
> gives the go-ahead, please guide me in how to make a branch and commit
> the code. 

We first need to decide if we still want to accept this new tool for the
2.4 release. Otherwise it would have to be committed to a branch and
merged into HEAD after the stable release is done.


Gimp-developer mailing list

Reply via email to