On 02/27/2010 03:14 PM, Jon Nordby wrote:
> Sets lower compression and disables interlacing.
> On a 5 layer image of 4500x6000px this gives an order of magnitude better
> save-times, with 50% increase in file size.

Hi Jon

Sorry for the late follow-up and thanks for maintaining the ORA plug-in.

50% increase in file size is pretty significant, maybe the compression 
ratio should be exposed in a UI?


> @@ -85,7 +85,7 @@ def save_ora(img, drawable, filename, raw_filename):
>
> def store_layer(img, drawable, path):
> tmp = os.path.join(tempdir, 'tmp.png')
> - pdb['file-png-save-defaults'](img, drawable, tmp, 'tmp.png')
> + pdb['file-png-save'](img, drawable, tmp, 'tmp.png', 0, 2, 1, 1, 1, 1, 1)

It would be nice to make 0, 2, 1, 1, 1, 1, 1 immediately interpretable, 
for example by commenting or using local variables like so:

   embed_profile = 1
   function(1, # save_comment
            embed_profile)


BR,
Martin
_______________________________________________
Gimp-developer mailing list
Gimp-developer@lists.XCF.Berkeley.EDU
https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer

Reply via email to