Zitat von "Sven Neumann" <s...@gimp.org>:

> On Wed, 2010-04-21 at 18:30 +0200, Martin Nordholts wrote:
>> On 04/21/2010 01:58 PM, Oliver Bandel wrote:
>> > Even only temporarily valies, if set to a certain value,
>> > like 0 or NULL, will help in finding problems.
>> I agree, and I try to initialize all local variables that I either add
>> or modify the declaration of. I don't think it would be worth to commit
>> a patch that initializes all variables though because it would break git
>> blame.
> I don't think the git history of a file is a reason that should keep
> anyone from committing code cleanups.

Oh, yes. I see it the same way.

> The question is rather if this
> particular cleanup is worth the hassle and if it would really result in
> an improvement when it comes to readability and maintainability of the
> code-base.

The answer from my experience is: it absolutely is worth it.

And I doubt that the code will ne that much more unreadable.
In situations where it bloats up the code, I would guess it
reasons that should better end in refactoring the code.


Gimp-developer mailing list

Reply via email to