Hi,

Right now, we put an artificial constraint on the toolbox dock window to make it resizeable only in tool button sized increments. If there is a dockable dialog present, the constraint is only on the width. If there are no dockables, the constraint is both on the width and the height.


The GtkToolPalette widget that hosts the buttons is able to nicely distribute available space among the buttons, so I would like to remove the resize constraint and make the toolbox dock window freely resizeable. The attached patch does that.

Are there any important use cases or interaction design aspects I'm not thinking about here?

 / Martin




--

My GIMP Blog:
http://www.chromecode.com/
"GIMP 2.8 development still under control"
>From 943d8d2219e19b3ae6dd288cd7f7f8bed7b16ff3 Mon Sep 17 00:00:00 2001
From: Martin Nordholts <mart...@src.gnome.org>
Date: Thu, 27 May 2010 09:15:08 +0200
Subject: [PATCH] app: Remove resize increment constraint on toolbox dock window

---
 app/widgets/gimptoolbox.c |    6 +-----
 1 files changed, 1 insertions(+), 5 deletions(-)

diff --git a/app/widgets/gimptoolbox.c b/app/widgets/gimptoolbox.c
index 564b751..c06a1eb 100644
--- a/app/widgets/gimptoolbox.c
+++ b/app/widgets/gimptoolbox.c
@@ -849,15 +849,11 @@ gimp_toolbox_set_host_geometry_hints (GimpDock  *dock,
       geometry.min_width  = (2 * border_width +
                              2 * button_requisition.width);
       geometry.min_height = -1;
-      geometry.width_inc  = button_requisition.width;
-      geometry.height_inc = (gimp_dock_get_dockbooks (GIMP_DOCK (toolbox)) ?
-                             1 : button_requisition.height);
 
       gtk_window_set_geometry_hints (window,
                                      NULL,
                                      &geometry,
-                                     GDK_HINT_MIN_SIZE   |
-                                     GDK_HINT_RESIZE_INC |
+                                     GDK_HINT_MIN_SIZE |
                                      GDK_HINT_USER_POS);
 
       gimp_dialog_factory_set_has_min_size (window, TRUE);
-- 
1.6.6.1

_______________________________________________
Gimp-developer mailing list
Gimp-developer@lists.XCF.Berkeley.EDU
https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer

Reply via email to