[ 
https://issues.apache.org/jira/browse/GIRAPH-18?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jakob Homan updated GIRAPH-18:
------------------------------

    Attachment: GIRAPH-18b.patch

Updated patch.  Removed all the two-space idents I could find, fixed point 1.  
Removed all the >80 chars except for instances of ");".  There are several 
other >80 lines in the code as is, so once the discussion settles down about 
style, we can adjust all of them as necessary.

The code style differs from the other projects I work on, so I'm fighting 
IntelliJ's autoformat.  I'll see about creating a style file for IntelliJ that 
could be included.

> Refactor BspServiceWorker::loadVertices()
> -----------------------------------------
>
>                 Key: GIRAPH-18
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-18
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: Jakob Homan
>            Assignee: Jakob Homan
>         Attachments: GIRAPH-18.patch, GIRAPH-18b.patch
>
>
> Currently BspServiceWorker::loadVertices() is more than 200 lines and 
> convoluted. I found it difficult to grok while debugging today.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to