[
https://issues.apache.org/jira/browse/GIRAPH-27?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13101009#comment-13101009
]
Jake Mannix commented on GIRAPH-27:
-----------------------------------
Ok, while I still hold that my previous comment is valid, it's probably
addressable in another ticket, as it requires looking at a whole bunch of
places (VertexResolver is one, but then
CentralizedService#getRepresentativeVertex() is another, and VertexRange also
needs to move from having Vertex in its Map, to MutableVertex).
While writing this comment, I tried out a refactoring on my branch which does
allow for the existence of a MutableVertex subclass which is *not* a Vertex
subclass, and in fact has, as a trial,
SimplePageRankVertex extends LongDoubleFloatDoubleVertex
and the unit tests all pass with this new class!
Probably needs tons of cleanup, but I can post it here if appropriate.
> Mutable static global state in Vertex.java should be refactored
> ---------------------------------------------------------------
>
> Key: GIRAPH-27
> URL: https://issues.apache.org/jira/browse/GIRAPH-27
> Project: Giraph
> Issue Type: Improvement
> Components: graph
> Affects Versions: 0.70.0
> Reporter: Jake Mannix
> Assignee: Jake Mannix
> Attachments: GIRAPH-27.patch, GIRAPH-27.patch
>
>
> Vertex.java has a bunch of static methods for getting/setting global graph
> state (total number of vertices, edges, a reference to the GraphMapper, etc).
> Refactoring this into a GraphState object, which every Vertex can hold onto
> a reference to (yes, a tiny bit more memory per Vertex, but in comparison to
> what's already in there...)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
