Avery Ching commented on GIRAPH-31:

committer +1.  A few minor formatting issues (missing javadoc and over 80 char 
lines - I can fix before committing), but otherwise great!  I agree with 
Dmitriy's comment that the default should be false.  We should probably wait 
(maybe a day) for other folks to chime in for this one since it's a user facing 

> Hide the SortedMap<I, Edge<I,E>> in Vertex from client visibility (impl. 
> detail), replace with appropriate accessor methods
> ---------------------------------------------------------------------------------------------------------------------------
>                 Key: GIRAPH-31
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-31
>             Project: Giraph
>          Issue Type: Improvement
>          Components: graph
>    Affects Versions: 0.70.0
>            Reporter: Jake Mannix
>            Assignee: Jake Mannix
>         Attachments: GIRAPH-31.diff
> As discussed on the list, and on GIRAPH-28, the SortedMap<I, Edge<I,E>> is an 
> implementation detail which needs not be exposed to application developers - 
> they need to iterate over the edges, and possibly access them one-by-one, and 
> remove them (in the Mutable case), but they don't need the SortedMap, and 
> creating primitive-optimized BasicVertex implementations is hampered by the 
> fact that clients expect this Map to exist.

This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to