----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2322/ -----------------------------------------------------------
Review request for giraph. Summary ------- 9 unittests failed due to java.lang.IllegalArgumentException at java.util.concurrent.ThreadPoolExecutor.<init>(ThreadPoolExecutor.java:589) at java.util.concurrent.ThreadPoolExecutor.<init>(ThreadPoolExecutor.java:480) at java.util.concurrent.Executors.newFixedThreadPool(Executors.java:59) at org.apache.giraph.comm.BasicRPCCommunications.<init>(BasicRPCCommunications.java:375) at org.apache.giraph.comm.RPCCommunications.<init>(RPCCommunications.java:68) at org.apache.giraph.graph.GraphMapper.map(GraphMapper.java:571) at org.apache.hadoop.mapreduce.Mapper.run(Mapper.java:144) at org.apache.hadoop.mapred.MapTask.runNewMapper(MapTask.java:763) at org.apache.hadoop.mapred.MapTask.run(MapTask.java:369) at org.apache.hadoop.mapred.LocalJobRunner$Job.run(LocalJobRunner.java:210) The issue is that with only a single worker, the ThreadpoolExecutor fails because of having 0 threads as an argument. This addresses bug GIRAPH-48. https://issues.apache.org/jira /browse/GIRAPH-48 Diffs ----- http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/comm/BasicRPCCommunications.java 1180785 Diff: https://reviews.apache.org/r/2322/diff Testing ------- Passed unittests. Thanks, Avery