Claudio Martella commented on GIRAPH-60:

As I'm implementing AggregatorsWriter, I realized I'd need to access 
getMergedAggregatorPath() to get the aggregated values to dump to disk. I 
wanted to avoid passing BspService to the implementation to hide it from the 

At second thought, as I can see that it's not so trivial 
(APPLICATION_ATTEMPTS_PATH is not a constant), I thought to make 
AggregatorsWriter an abstract class where we would have a setBspService() 
called by us at instantiation (a bit like what happens now with GraphState 
somewhere else) and a final JsonObject getMergedValues() method that would 
return directly the aggregated values to the user. This would allow us to hide 
BspService and all the machine under the hood and provide the user the merged 
values ready to write. I'll work on this idea. What do you think?
> Export BspService public get*Path() methods through static
> ----------------------------------------------------------
>                 Key: GIRAPH-60
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-60
>             Project: Giraph
>          Issue Type: Improvement
>          Components: graph
>    Affects Versions: 0.70.0
>            Reporter: Claudio Martella
>            Assignee: Claudio Martella
>            Priority: Trivial
>             Fix For: 0.70.0
> BspService has methods to compose Paths such as getSuperstepPath() etc. that 
> could be used by other non-implementing classes. We should export them 
> through static.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to