Avery Ching commented on GIRAPH-62:

Jakob, it looks great.  I think it's simpler than using 
TextVertexInputFormat/TextVertexOutputFormat.  I like the use of mockito for 
unittesting.  Some minor formatting nits:

Our new agreement is 2 spaces of indentation and 4 for overruns.  The old way 
is 4 and 8 respectively.  

For src/main/java/org/apache/giraph/graph/Edge.java, I agree to stick with the 
current formatting until it's all changed (later).

For the new files, you can do either 2 or 4, but I saw a mix in there, please 
pick one.

Also, saw some 'if(expr)' instead of 'if (expr)'.

Would be great if you can clean this up prior to commit.
> Provide input format for reading graphs stored as adjacency lists
> -----------------------------------------------------------------
>                 Key: GIRAPH-62
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-62
>             Project: Giraph
>          Issue Type: New Feature
>          Components: lib
>            Reporter: Jakob Homan
>            Assignee: Jakob Homan
>         Attachments: GIRAPH-62.patch
> We should provide as many options for getting data in/out of Giraph as 
> possible.  One common format is adjacency lists, with each edge id, its 
> value, and its edges and their values per line.  It would be good to provide 
> inputformats to handle this type of data with minimal effort from the user.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to