[
https://issues.apache.org/jira/browse/GIRAPH-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13139098#comment-13139098
]
Jake Mannix commented on GIRAPH-36:
-----------------------------------
Hmm... on further thought: passing getRecordReader().getCurrentValue() requires
the parsing happen in the Vertex implementation. That work is the primary
*job* of the VertexReader, so I think we're going to need something like:
{code}
class BasicVertex<I,V,E,M> {
abstract void initialize(I id, V val, Map<I,E> edges, Iterable<M> message);
}
{code}
Of course, we could also just use *gasp* a constructor?
> Ensure that subclassing BasicVertex is possible by user apps
> ------------------------------------------------------------
>
> Key: GIRAPH-36
> URL: https://issues.apache.org/jira/browse/GIRAPH-36
> Project: Giraph
> Issue Type: Improvement
> Components: graph
> Affects Versions: 0.70.0
> Reporter: Jake Mannix
> Assignee: Jake Mannix
> Priority: Blocker
> Fix For: 0.70.0
>
>
> Original assumptions in Giraph were that all users would subclass Vertex
> (which extended MutableVertex extended BasicVertex). Classes which wish to
> have application specific data structures (ie. not a TreeMap<I, Edge<I,E>>)
> may need to extend either MutableVertex or BasicVertex. Unfortunately
> VertexRange extends ArrayList<Vertex>, and there are other places where the
> assumption is that vertex classes are either Vertex, or at least
> MutableVertex.
> Let's make sure the internal APIs allow for BasicVertex to be the base class.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
