Avery Ching commented on GIRAPH-36:


Your suggestion on 1) will work, but couldn't we also just use the 
infrastructure to set graph state after getCurrentVertex()?  There is no need 
to use the GraphState state at that point of the application.  It potentially 
will prevent users from making any mistakes and complicating GraphState, which 
is owned by the Worker.

Per 2), this is a downside of changing the interface I think.  I guess we will 
have to live with the additional M type.  It's not a big deal to me.  That 
being said, we should prevent users from initializing vertices with messages 
from the vertex reader since I don't think that makes any sense...or does it?
> Ensure that subclassing BasicVertex is possible by user apps
> ------------------------------------------------------------
>                 Key: GIRAPH-36
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-36
>             Project: Giraph
>          Issue Type: Improvement
>          Components: graph
>    Affects Versions: 0.70.0
>            Reporter: Jake Mannix
>            Assignee: Jake Mannix
>            Priority: Blocker
>             Fix For: 0.70.0
>         Attachments: GIRAPH-36.diff
> Original assumptions in Giraph were that all users would subclass Vertex 
> (which extended MutableVertex extended BasicVertex).  Classes which wish to 
> have application specific data structures (ie. not a TreeMap<I, Edge<I,E>>) 
> may need to extend either MutableVertex or BasicVertex.  Unfortunately 
> VertexRange extends ArrayList<Vertex>, and there are other places where the 
> assumption is that vertex classes are either Vertex, or at least 
> MutableVertex.
> Let's make sure the internal APIs allow for BasicVertex to be the base class.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to