[ https://issues.apache.org/jira/browse/GIRAPH-73?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13147913#comment-13147913 ]
Avery Ching commented on GIRAPH-73: ----------------------------------- Hi Sebastian, Thanks for the refactoring and for taking a look at the code. Have you looked at the CODE_CONVENTIONS in the base directory, I see a little bit of weird indenting (not a big deal). After a quick pass, looks like you have make some nice improvements in the code. Now that we have added Guava, why not take advantage as you have suggested? Also, regarding - DoubleWritable> vertex = BspUtils.<LongWritable, DoubleWritable, FloatWritable, - DoubleWritable>createVertex(getContext().getConfiguration()); + DoubleWritable> vertex = BspUtils.createVertex(getContext().getConfiguration()); We have had issues when types aren't specified. See http://stackoverflow.com/questions/2640060/inconsistency-between-sun-jre-javac-and-eclipse-java-compiler and an issue (https://issues.apache.org/jira/browse/GIRAPH-27). Also, were you able to pass unittests locally (mvn test) and on a actual Hadoop instance (mvn test -Dprop.mapred.job.tracker=<jobtracker>:<jobtracker_port>)? > A little refactoring > -------------------- > > Key: GIRAPH-73 > URL: https://issues.apache.org/jira/browse/GIRAPH-73 > Project: Giraph > Issue Type: Improvement > Affects Versions: 0.70.0 > Reporter: Sebastian Schelter > Priority: Minor > Attachments: GIRAPH-73.patch > > > Hi, I'm currently reading Giraph's sources and starting to play with it. I > fixed some small things along the way (like making sure writers are closed, > exceptions are logged, etc.), thought that maybe helpful. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira