Jakob Homan updated GIRAPH-64:

    Attachment: GIRAPH-64-2.patch

Updated patch for Jake's comments.  Outputformat is no longer a required param 
(though will open a new JIRA to make it so; defaulting to /dev/null is bad) and 
inputpath is correctly used.  

Hyunsik: mvn assembly:single (or assembly, but that's been deprecated for 
single) won't work since we're defining separate assemblies (either the regular 
or fat jar), and no default is provided.  I tried adding one, but it generated 
basically an empty .tar.gz, which is pretty useless. It might be better to 
error out than create an empty file.  This will go away once we get rid of the 

Avery: I can't reproduce what you saw and I'm a bit confused because the error 
is referencing lines 136-150 in GiraphRunner, but that file is only 117 lines 
long.  Can you try it again with this patch on a fresh checkout? 
> Create VertexRunner to make it easier to run users' computations
> ----------------------------------------------------------------
>                 Key: GIRAPH-64
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-64
>             Project: Giraph
>          Issue Type: New Feature
>            Reporter: Jakob Homan
>            Assignee: Jakob Homan
>         Attachments: GIRAPH-64-2.patch, GIRAPH-64.patch
> Currently, if a user wants to implement a Giraph algorithm by extending 
> {{Vertex}} they must also write all the boilerplate around the {{Tool}} 
> interface and bundle it with the Giraph jar (or get Giraph on the classpath 
> and playing nice with the implementation).  For example, what is included in 
> the PageRankBenchmark and what Kohei has done: 
> https://github.com/smly/java-Giraph-LabelPropagation  It would be better if 
> we had perhaps a Vertex implementation to be subclassed that already had all 
> the standard Tooling included such that all one had to run would be (assuming 
> the Giraph jar was already on the classpath):
> {noformat}hadoop jar my-awesome-vertex.jar my.awesome.vertex -i jazz_input -o 
> jazz_output -if org.apache.giraph.lib.in.text.adjacency-list.LongDoubleDouble 
> -of org.apache.giraph.lib.out.text.adjacency-list.LongDoubleDouble{noformat} 
> This wouldn't work with every algorithm, but would be useful in a large 
> number of cases.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to