[ 
https://issues.apache.org/jira/browse/GIRAPH-11?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13149485#comment-13149485
 ] 

Hyunsik Choi commented on GIRAPH-11:
------------------------------------

You are welcome. But, the second patch still occurs the following error:

{code}
hyunsik@code:~/Code/giraph/giraph-trunk$ patch -p0 < 
~/Downloads/GIRAPH-11.2.diff patching file pom.xml
patching file 
src/main/java/org/apache/giraph/benchmark/PseudoRandomVertexInputFormat.java
patching file src/main/java/org/apache/giraph/bsp/CentralizedServiceWorker.java
patching file src/main/java/org/apache/giraph/comm/BasicRPCCommunications.java
patching file src/main/java/org/apache/giraph/comm/CommunicationsInterface.java
patching file src/main/java/org/apache/giraph/comm/RPCCommunications.java
patching file src/main/java/org/apache/giraph/comm/ServerInterface.java
patching file src/main/java/org/apache/giraph/comm/WorkerCommunications.java
patching file 
src/main/java/org/apache/giraph/examples/GeneratedVertexInputFormat.java
patching file 
src/main/java/org/apache/giraph/examples/GeneratedVertexReader.java
patching file src/main/java/org/apache/giraph/examples/MaxAggregator.java
patching file src/main/java/org/apache/giraph/examples/MinAggregator.java
patching file 
src/main/java/org/apache/giraph/examples/SimpleMutateGraphVertex.java
patching file 
src/main/java/org/apache/giraph/examples/SimpleSuperstepVertex.java
patching file src/main/java/org/apache/giraph/examples/SuperstepBalancer.java
patching file 
src/main/java/org/apache/giraph/examples/SuperstepHashPartitioner.java
patching file src/main/java/org/apache/giraph/examples/VerifyMessage.java
patching file src/main/java/org/apache/giraph/graph/AutoBalancer.java
patching file src/main/java/org/apache/giraph/graph/BasicVertex.java
patching file 
src/main/java/org/apache/giraph/graph/BasicVertexRangeBalancer.java
patching file src/main/java/org/apache/giraph/graph/BspService.java
patching file src/main/java/org/apache/giraph/graph/BspServiceMaster.java
patching file src/main/java/org/apache/giraph/graph/BspServiceWorker.java
patching file src/main/java/org/apache/giraph/graph/BspUtils.java
patching file src/main/java/org/apache/giraph/graph/GiraphJob.java
patching file src/main/java/org/apache/giraph/graph/GlobalStats.java
patching file src/main/java/org/apache/giraph/graph/GraphMapper.java
patching file src/main/java/org/apache/giraph/graph/GraphState.java
patching file 
src/main/java/org/apache/giraph/graph/LongDoubleFloatDoubleVertex.java
patching file src/main/java/org/apache/giraph/graph/MutableVertex.java
patching file src/main/java/org/apache/giraph/graph/StaticBalancer.java
patching file src/main/java/org/apache/giraph/graph/Vertex.java
patching file src/main/java/org/apache/giraph/graph/VertexEdgeCount.java
patching file src/main/java/org/apache/giraph/graph/VertexRange.java
patching file src/main/java/org/apache/giraph/graph/VertexRangeBalancer.java
patching file src/main/java/org/apache/giraph/graph/WorkerInfo.java
patching file 
src/main/java/org/apache/giraph/graph/partition/BasicPartitionOwner.java
patching file 
src/main/java/org/apache/giraph/graph/partition/GraphPartitioner.java
patching file 
src/main/java/org/apache/giraph/graph/partition/HashMasterPartitioner.java
patching file 
src/main/java/org/apache/giraph/graph/partition/HashPartitioner.java
patching file 
src/main/java/org/apache/giraph/graph/partition/HashRangePartitioner.java
patching file 
src/main/java/org/apache/giraph/graph/partition/HashRangeWorkerPartitioner.java
patching file 
src/main/java/org/apache/giraph/graph/partition/HashWorkerPartitioner.java
patching file 
src/main/java/org/apache/giraph/graph/partition/MasterGraphPartitioner.java
patching file src/main/java/org/apache/giraph/graph/partition/Partition.java
patching file 
src/main/java/org/apache/giraph/graph/partition/PartitionBalancer.java
patching file 
src/main/java/org/apache/giraph/graph/partition/PartitionExchange.java
patching file 
src/main/java/org/apache/giraph/graph/partition/PartitionOwner.java
patching file 
src/main/java/org/apache/giraph/graph/partition/PartitionStats.java
patching file 
src/main/java/org/apache/giraph/graph/partition/PartitionUtils.java
patching file 
src/main/java/org/apache/giraph/graph/partition/RangeMasterPartitioner.java
patching file 
src/main/java/org/apache/giraph/graph/partition/RangePartitionOwner.java
patching file 
src/main/java/org/apache/giraph/graph/partition/RangePartitionStats.java
patching file 
src/main/java/org/apache/giraph/graph/partition/RangePartitioner.java
patching file 
src/main/java/org/apache/giraph/graph/partition/RangeSplitHint.java
patching file 
src/main/java/org/apache/giraph/graph/partition/RangeWorkerPartitioner.java
patching file 
src/main/java/org/apache/giraph/graph/partition/WorkerGraphPartitioner.java
patching file src/main/java/org/apache/giraph/utils/WritableUtils.java
patching file src/main/java/org/apache/giraph/zk/ZooKeeperExt.java
patching file src/test/java/org/apache/giraph/TestMutateGraphVertex.java
patching file src/test/java/org/apache/giraph/TestVertexRangeBalancer.java
Hunk #2 FAILED at 52.
Hunk #3 FAILED at 86.
Hunk #4 FAILED at 106.
Hunk #5 succeeded at 131 (offset 6 lines).
3 out of 5 hunks FAILED -- saving rejects to file 
src/test/java/org/apache/giraph/TestVertexRangeBalancer.java.rej
patching file src/test/java/org/apache/giraph/TestVertexRangeBalancer.java
{code}

It may be caused by the moved file (i.e., TestVertexRangeBalancer.java -> 
TestGraphPartitioner.java). First of all, I manually merged the two files for 
review.

Thank you

                
> Improve the graph distribution of Giraph
> ----------------------------------------
>
>                 Key: GIRAPH-11
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-11
>             Project: Giraph
>          Issue Type: Improvement
>    Affects Versions: 0.70.0
>            Reporter: Avery Ching
>            Assignee: Avery Ching
>         Attachments: GIRAPH-11.2.diff, GIRAPH-11.diff
>
>
> Currently, Giraph assumes that the data from the VertexInputFormat is sorted. 
>  If the user data is not sorted by the vertex id, they must first run a 
> MapReduce or Pig job to generate a sorted dataset.  This is often a bit 
> inconvenient.
> Giraph graph partitioning is currently range based and there are some 
> advantages and disadvantages of this approach.  The proposal of this JIRA 
> would be to allow for both range and hash based partitioning and provide more 
> flexibility to the user.
> Design goals for the graph distribution:
> * Allow vertices to be unordered or unordered
> * Ability to repartition
> * Select the partitioning scheme based on user needs (i.e. hash or range 
> based)
> * Ability to provide user-specific hints about partitions
> Hash-based partitioning
> * Good vertex balancing across ranges for random data
> * Bad at vertex id locality
> Range-based partitioning
> * Good at vertex id locality
> * Ability to split ranges easily
> * Can cause hotspots for hot ranges

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to