[ 
https://issues.apache.org/jira/browse/GIRAPH-74?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13150724#comment-13150724
 ] 

Claudio Martella commented on GIRAPH-74:
----------------------------------------

Apparently I'm not. I cannot reach once again SVN (by the way is it me or is it 
normal? it happens often). If you have changed the API accordingly, i'll check 
those Vertex that should be Basic Vertex that were missing before.

But from your message it looks like I'll need to change the field to a 
package-level set/get methods as well.
                
> GIRAPH-36 missed a couple of liners when passing from Vertex to BasicVertex
> ---------------------------------------------------------------------------
>
>                 Key: GIRAPH-74
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-74
>             Project: Giraph
>          Issue Type: Bug
>          Components: graph
>    Affects Versions: 0.70.0
>            Reporter: Claudio Martella
>            Assignee: Claudio Martella
>             Fix For: 0.70.0
>
>         Attachments: GIRAPH-36-cleaup.diff, GIRAPH-70.diff
>
>
> After GIRAPH-36, in a couple of places Vertex was left instead of 
> BasicVertex. To achieve the fix a BasicVertex was extended with a new boolean 
> isHalted(boolean state) method that totally hides boolean halt field. I 
> believe this unifies the voteToHalt() and isHalted() methods totally hiding 
> the halting management of Vertices (before it was relying on the existence of 
> boolean halt field).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to