Avery Ching commented on GIRAPH-68:

Looks good Hyunsik, a few comments.

Probably want to add a javadoc comment for GraphGenerator
Lines 40-41: Should have 8 space indenting
Line 46: needs 4 more spaces
Line 58: Over 80 chars

So is the idea that PageRankBenchmark and RandomMessageBenchmark would use it?  
Would you like to modify them to do so?
> Implement a Graph Generator
> ---------------------------
>                 Key: GIRAPH-68
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-68
>             Project: Giraph
>          Issue Type: New Feature
>          Components: benchmark
>    Affects Versions: 0.70.0
>            Reporter: Hyunsik Choi
>            Assignee: Hyunsik Choi
>         Attachments: GIRAPH-68_1.patch
> To provide users with benchmark environments and to deeply test the 
> input/output system of giraph, we need a graph generator. We will enable the 
> graph generator to generate various kinds of graph data sets by specifying a 
> VertexInputFormat and a VertexOutputFormat.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to