Jakob Homan commented on GIRAPH-83:

bq. I think it should probably actually be called Vertex, because everything 
"is a" BasicVertex currently, so it makes sense instead to say everything "is 
a" Vertex.
Absolutely agreed.

bq. We can factor off lots of stuff into other classes, but the question comes 
down to how does the user writing their algorithm get access to them? How is it 
all wired together? You want compute() to get passed some state that you have 
right when you need it, instead of either going with inheritance or 
composition? That could be nice, I think, as long as we package it all up into 
a minimal set of *Context-like objects to carry around.
Correct, this is what I'm getting at.

bq. In what way are the out edges of a vertex "managed by the framework" 
In that Vertex is responsible for maintaining the destEdgeMap for an 
implementation of Vertex, rather than implementers having to do this 
themselves.  For each compute invocation, the vertex shouldn't assume anything 
about its outgoing edges, as they may have been mutated since the last call.
> Is Vertex correct yet?
> ----------------------
>                 Key: GIRAPH-83
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-83
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: Jakob Homan
> I'm seeing a number of people run into oddities with Vertex and am thinking 
> we may not have it quite correct yet...

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to