Shaunak Kashyap commented on GIRAPH-84:

I believe that style goes against the coding conventions for this project (see 

I wonder if using the ternary operator like so is acceptable:

return (seenRecord ? 1f : 0f);
> Simplify boolean expressions in BspRecordReader
> -----------------------------------------------
>                 Key: GIRAPH-84
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-84
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: Jakob Homan
>            Assignee: Attila Csordas
>              Labels: newbie
> Twice in BspRecordReader boolean expressions are evaluated with == and can be 
> simplified to just one liners or variable evaluation.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to