Avery Ching commented on GIRAPH-10:

Thanks for the revised diff.  I have some suggestions, let me know what you 

First, you are missing 

org.apache.giraph.examples.SimpleAggregatorWriter in the diff.

Hence I am getting errors in my build:

 cannot find symbol
symbol  : class SimpleAggregatorWriter
location: package org.apache.giraph.examples
 cannot find symbol

Also, your IDE is using tabs.  The CODE_CONVENTIONS asks for spaces instead of 
tabs.  Can you please convert all your tabs to spaces?

In AggreatorWriter.java
- Quite a few tabs in this file, please changes to spaces.
- Indentation issues lines: 60 and greater in AggregatorWriter.java
- line 52: "The methods is called at the" => "This method is called at the"
- line 60: map is a bit non-descriptive here.  Can you change it to something 
else, i.e. aggregatorNameValueMap or even just aggregatorMap?
- line 64: "successfull" => "successful"

-line 44: aggreatos -> aggregators

- line 371:  "for (i=0; ; i++) {" =>  "for (i = 0; ; i++) {"

> Aggregators are not exported
> ----------------------------
>                 Key: GIRAPH-10
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-10
>             Project: Giraph
>          Issue Type: New Feature
>            Reporter: Avery Ching
>            Assignee: Claudio Martella
>            Priority: Minor
>         Attachments: GIRAPH-10.diff, GIRAPH-10.diff
> Currently, aggregator values cannot be saved after a Giraph job.  There 
> should be a way to do this.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to