-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3201/
-----------------------------------------------------------

Review request for giraph.


Summary
-------

Added new putVertexIdMessagesList RPC and supporting classes (VertexIdMessages 
and VertexIdMessagesList) to reduce the total number of RPCs during a flush.  
This improves the number of RPC / sec and overall I/O bandwidth.  The amount of 
batching is done by the total number of messages and is configurable at runtime 
(default of 5000, weighted toward helping smaller messages).  I have noted some 
performance results in https://issues.apache.org/jira/browse/GIRAPH-57 (between 
25 - 1075 percent improvements).

Also, while tinkering with BasicRPCCommunications, notices inconsistent spaces 
between 'synchronized' and '('.  Removed spaces and standardized in the 
CODE_CONVENTIONS.


This addresses bug GIRAPH-57.
    https://issues.apache.org/jira/browse/GIRAPH-57


Diffs
-----

  http://svn.apache.org/repos/asf/incubator/giraph/trunk/CODE_CONVENTIONS 
1213849 
  
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/comm/ArrayListWritable.java
 1213849 
  
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/comm/BasicRPCCommunications.java
 1214406 
  
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/comm/CommunicationsInterface.java
 1213849 
  
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/GiraphJob.java
 1213849 

Diff: https://reviews.apache.org/r/3201/diff


Testing
-------

Passed local and Hadoop unittests.  Used the RandomMessageBenchmark on a small 
cluster.


Thanks,

Avery

Reply via email to