-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3203/
-----------------------------------------------------------

(Updated 2011-12-17 09:35:51.778265)


Review request for giraph.


Changes
-------

Updated the patch to include proposed changes. Unfortunately setMessages(...) 
cannot be package-private as it is invoked by BasicRPCCommunications.

Ran tests in local and pseudo-distributed mode.


Summary
-------

refactoring that gives BasicVertex this 3 new methods:

    public abstract Iterable<M> getMessages()

returns an unmodifiable iterable allowing access to the current messages

    public abstract void setMessages(Iterable<M> messages);

replacement for getMsgList().clear() followed by getMsgList().addAll(...);

    public abstract void releaseResources();

after a vertex voted to halt, all references to messages it could still hold 
should be removed to enable earlier GC, instead of externally calling 
replacement for getMsgList().clear(), this method should be used

Local unit tests pass, unfortunately I wasn't yet able to run the tests on my 
hadoop cluster (still have problems because I can only access it via a socks 
proxy)


This addresses bug GIRAPH-80.
    https://issues.apache.org/jira/browse/GIRAPH-80


Diffs (updated)
-----

  /trunk/src/main/java/org/apache/giraph/comm/BasicRPCCommunications.java 
1215442 
  /trunk/src/main/java/org/apache/giraph/graph/BasicVertex.java 1215442 
  /trunk/src/main/java/org/apache/giraph/graph/BasicVertexResolver.java 1215442 
  /trunk/src/main/java/org/apache/giraph/graph/EdgeListVertex.java 1215442 
  /trunk/src/main/java/org/apache/giraph/graph/GraphMapper.java 1215442 
  /trunk/src/main/java/org/apache/giraph/graph/LongDoubleFloatDoubleVertex.java 
1215442 
  /trunk/src/main/java/org/apache/giraph/graph/Vertex.java 1215442 
  /trunk/src/main/java/org/apache/giraph/graph/VertexResolver.java 1215442 
  /trunk/src/main/java/org/apache/giraph/utils/ComparisonUtils.java 
PRE-CREATION 
  /trunk/src/main/java/org/apache/giraph/utils/MemoryUtils.java 1215442 
  /trunk/src/test/java/org/apache/giraph/utils/ComparisonUtilsTest.java 
PRE-CREATION 

Diff: https://reviews.apache.org/r/3203/diff


Testing
-------


Thanks,

Sebastian

Reply via email to