Sebastian Schelter commented on GIRAPH-105:

Makes sense. Main issue is to make caller and callee consistent.
> BspServiceMaster.checkWorkers() should return empty lists instead of null
> -------------------------------------------------------------------------
>                 Key: GIRAPH-105
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-105
>             Project: Giraph
>          Issue Type: Bug
>    Affects Versions: 0.70.0
>            Reporter: Sebastian Schelter
>            Priority: Minor
>         Attachments: GIRAPH-105.patch
> BspServiceMaster.checkWorkers() is invoked in 
> BspServiceMaster.coordinateSuperstep() and in 
> BspServiceMaster.createInputSplits(). Both check for an empty list to fail 
> the job in case something has gone wrong. However, checkWorkers() returns 
> null in case of problems, causing an NPE in the calling code.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to