[ 
https://issues.apache.org/jira/browse/GIRAPH-119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181566#comment-13181566
 ] 

Avery Ching commented on GIRAPH-119:
------------------------------------

Minor nit

         @Override
         public FloatWritable combine(LongWritable vertexIndex,
-                                  List<FloatWritable> msgList)
+                                  Iterable<FloatWritable> msgList)
                 throws IOException {
             return null;
         }
@@ -97,7 +97,7 @@ public class TestVertexTypes
 
         @Override
         public DoubleWritable combine(LongWritable vertexIndex,
-                                      List<DoubleWritable> msgList)
+                                      Iterable<DoubleWritable> msgList)
                 throws IOException {
             return null;
         }

probably should have changed msgList to messages or something like that.  Not a 
big deal.  =)
                
> VertexCombiner should work on Iterable<M> instead of List<M>
> ------------------------------------------------------------
>
>                 Key: GIRAPH-119
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-119
>             Project: Giraph
>          Issue Type: Improvement
>          Components: graph
>    Affects Versions: 0.70.0
>            Reporter: Claudio Martella
>            Assignee: Claudio Martella
>         Attachments: GIRAPH-119.diff
>
>
> Currently VertexCombiner expects a List<M>. It should be refactored to 
> Iterable<M> to sync with Iterable-based BasicVertex messages logics.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to