Avery Ching commented on GIRAPH-118:

Seems reasonable.  Please make sure to update the javadoc and the MutableVertex 
> Clarify messages behavior in BasicVertex
> ----------------------------------------
>                 Key: GIRAPH-118
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-118
>             Project: Giraph
>          Issue Type: Improvement
>          Components: graph
>    Affects Versions: 0.70.0
>            Reporter: Claudio Martella
>            Assignee: Claudio Martella
>            Priority: Minor
> initialize() can receive a null parameter for messages (at least that's what 
> EdgeListVertex does). We should avoid that and pass an empty Iterable 
> instead. That should be cheap for us inside of the InputFormat, just passing 
> a static immutable empty list.
> setMessages(Iterable<M>) should be changed to putMessages(Iterable<M>). the 
> set prefix suggests an assignment, while setMessages is used to transfer the 
> messages to the internal datastructure the user is responsible for. 
> putMessages() should clarify this.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to