----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3596/ -----------------------------------------------------------
(Updated 2012-01-28 01:15:26.114994) Review request for giraph. Changes ------- Removed whitspace changes for MinimumIntCombiner.java and SimpleSumCombiner.java and made GiraphJob.MAX_RPC_PORT_BIND_ATTEMPTS configurable, but default to 20. Summary ------- Simple handling of port collisions on the same machine while preserving debugability from the port number alone. Round up the max number of workers to the next power of 10 and use it as a constant to increase the port number with. Added a unit test to ensure it is working correctly. Fixed 2 minor warnings on src/main/java/org/apache/giraph/examples/MinimumIntCombiner.java src/main/java/org/apache/giraph/examples/SimpleSumCombiner.java of removing 'import java.util.List'. This addresses bug GIRAPH-128. https://issues.apache.org/jira/browse/GIRAPH-128 Diffs (updated) ----- http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/comm/BasicRPCCommunications.java 1236935 http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/GiraphJob.java 1236935 http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/test/java/org/apache/giraph/comm/RPCCommunicationsTest.java PRE-CREATION Diff: https://reviews.apache.org/r/3596/diff Testing ------- Passed local and MR unittests. Thanks, Avery