Avery Ching commented on GIRAPH-139:

Hi Jakob, I generally agree with what you have done and was able to use 
bin/giraph to execute your command (one minor change).

./bin/giraph -DPageRankBenchmark.superstepCount=200  
-DpseudoRandomVertexReader.edgesPerVertex=37 target/giraph-0.2-SNAPSHOT.jar 
org.apache.giraph.benchmark.HashMapVertexPageRankBenchmark  -w 2  -if 
org.apache.giraph.benchmark.PseudoRandomVertexInputFormat -of 
org.apache.giraph.lib.AdjacencyListTextVertexOutputFormat -op benchmark_results

However, I don't see why we need to remove the run() and main() methods from 
PageRankBenchmark.java.  Why not have both methods to run the benchmark?  As 
you've already mentioned, it is a bit verbose to run the above command.  I 
agree that using bin/giraph is probably the right way to go in the future, 
however.  Once we bin/giraph is nearly as easy to run as invoking main() 
directly, main() won't be necessary.

One very minor comment:

HashMapVertexPageRankBenchmark.java:28 - Benchmark -> benchmark
> Change PageRankBenchmark to be accessible via bin/giraph
> --------------------------------------------------------
>                 Key: GIRAPH-139
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-139
>             Project: Giraph
>          Issue Type: Improvement
>    Affects Versions: 0.2.0
>            Reporter: Jakob Homan
>            Assignee: Jakob Homan
>             Fix For: 0.2.0
>         Attachments: GIRAPH-139.patch
> Currently the PageRankBenchmark has its own main and tool implementation and 
> is difficult to access from the bin/giraph script.  It would be better if 
> everything were accessible via bin/giraph.  The benchmark is particularly 
> problematic because it uses inner classes for its two actual Vertex 
> implementations, which have to be specified on the command line as their 
> .class name(ie 
> org.apache.giraph.benchmark.PageRankBenchmark$PageRankHashMapVertex) rather 
> than just with dots, as one would expect.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to