Jakob Homan commented on GIRAPH-139:

bq. However, I don't see why we need to remove the run() and main() methods 
from PageRankBenchmark.java. Why not have both methods to run the benchmark?
My concern is twofold: code duplication, in that most of the code in 
PageRankBenchmark duplicates code in GiraphRunner, and user confusion over 
which approach is correct.  I ran into issues trying to run the benchmark via 
main.  Also, since PageRankBenchmark had to be refactored into separate classes 
to support the two vertex types, it will require adjusting the main driver 
code, which means we're fixing duplicated code already.  Is it better to work 
on making bin/giraph easier to use than to expend that energy on maintaining 
duplicate code?  

Eventually, I would like to get the benchmark code into the examples directory 
and have it work the same way the example jar for Hadoop does: one can do 
bin/giraph giraph-examples.jar and be presented with all the example programs 
available and how to run them.
> Change PageRankBenchmark to be accessible via bin/giraph
> --------------------------------------------------------
>                 Key: GIRAPH-139
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-139
>             Project: Giraph
>          Issue Type: Improvement
>    Affects Versions: 0.2.0
>            Reporter: Jakob Homan
>            Assignee: Jakob Homan
>             Fix For: 0.2.0
>         Attachments: GIRAPH-139.patch
> Currently the PageRankBenchmark has its own main and tool implementation and 
> is difficult to access from the bin/giraph script.  It would be better if 
> everything were accessible via bin/giraph.  The benchmark is particularly 
> problematic because it uses inner classes for its two actual Vertex 
> implementations, which have to be specified on the command line as their 
> .class name(ie 
> org.apache.giraph.benchmark.PageRankBenchmark$PageRankHashMapVertex) rather 
> than just with dots, as one would expect.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to