Jakob Homan commented on GIRAPH-144:

bq. I have already submitted a patch that handles this with composition, but 
exposes the internal job object when necessary (i.e. 
FileInputFormat.addInputPath).  This should give us the benefits of composition 
while allowing us to still call convenience methods on the Job object.
Yeah... hmmm... Exposing the field via a getter method bugs me a bit.  It seems 
like the worst of both worlds; GiraphJob is no longer a Job, and we don't have 
any control over the Job that is being shown.  
> GiraphJob should not extend Job  (users should not be able to call Job 
> methods like waitForCompletion or setMapper..etc)
> ------------------------------------------------------------------------------------------------------------------------
>                 Key: GIRAPH-144
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-144
>             Project: Giraph
>          Issue Type: Bug
>            Reporter: Dave
>            Assignee: Avery Ching
>         Attachments: GIRAPH-144.patch
>   Original Estimate: 24h
>  Remaining Estimate: 24h

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to