[ 
https://issues.apache.org/jira/browse/GIRAPH-40?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Avery Ching updated GIRAPH-40:
------------------------------

    Attachment: GIRAPH-40.patch

I began with the commons-math checkstyle file and added and removed checks 
until I got to the closest interpretation of our CODE_CONVENTIONS.  This is 
mostly pretty close to our CODE_CONVENTIONS with a few exceptions.

I have formatted a few files and to show folks.  If you guys like it, I'll 
format the entire Giraph codebase and make this checkstyle enforceable.

I really believe that adding checkstyle will make our contribution process more 
smooth and allow us to work faster.
                
> Adding checkstyle enforcement of Giraph code conventions
> --------------------------------------------------------
>
>                 Key: GIRAPH-40
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-40
>             Project: Giraph
>          Issue Type: New Feature
>            Reporter: Avery Ching
>            Assignee: Avery Ching
>            Priority: Minor
>         Attachments: GIRAPH-40.patch
>
>
> Now that we have some code conventions (see GIRAPH-21), we should enforce 
> them with a maven checkstyle plugin.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to