Avery Ching commented on GIRAPH-85:

I just looked at your patch in Eclipse and see that there is now a warning due 

Type safety: Unchecked cast from VersionedProtocol to 

We can either keep this the way it was before, or add 
@SuppressWarnings("unchecked") to the method.  I don't have a strong opinion 
here.  Anyone else care to comment?

> Simplify return expression in RPCCommunications::getRPCProxy
> ------------------------------------------------------------
>                 Key: GIRAPH-85
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-85
>             Project: Giraph
>          Issue Type: Improvement
>    Affects Versions: 0.2.0
>            Reporter: Jakob Homan
>              Labels: newbie
>             Fix For: 0.2.0
>         Attachments: GIRAPH-85.patch, GIRAPH-85.patch
> Twice in RPCCommunications::getRPCProxy a local variable, proxy, is created 
> and immediately returned.  We can simplify this to just return the value.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to