Jakob Homan commented on GIRAPH-144:

Sorry, had missed the first ping.  Composition is definitely the way to go, I'm 
just still a bit worried about exposing the underlying Job.  Once we go to 
YARN, there's no reason to think that there will be a Job anymore to expose.  
It might be time to pull in Hadoop's interface classifications and mark that 
method as private unstable...  But this approach is better than what we have 
now, so go ahead with it until we come up with something better.
> GiraphJob should not extend Job  (users should not be able to call Job 
> methods like waitForCompletion or setMapper..etc)
> ------------------------------------------------------------------------------------------------------------------------
>                 Key: GIRAPH-144
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-144
>             Project: Giraph
>          Issue Type: Bug
>            Reporter: Dave
>            Assignee: Avery Ching
>         Attachments: GIRAPH-144.patch
>   Original Estimate: 24h
>  Remaining Estimate: 24h

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to