Dionysios Logothetis commented on GIRAPH-160:

I see two options here:

1) There is one AdjacencyListVertexReader abstract class and then two 
subclasses that implement their own getCurrentVertex() method.

2) There is a single AdjacencyListVertexReader and a configuration parameter 
defines whether vertices and edges have associated values.

I'd go for option (2). There's little code that's different inside 
getCurrentVertex(). We'd end up duplicating code again with option (1).

What do you think?
> Vertex reader that reads adjacency lists with no vertex and edge values 
> associated
> ----------------------------------------------------------------------------------
>                 Key: GIRAPH-160
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-160
>             Project: Giraph
>          Issue Type: New Feature
>          Components: lib
>    Affects Versions: 0.1.0
>            Reporter: Dionysios Logothetis
>            Assignee: Dionysios Logothetis
>            Priority: Minor
>              Labels: features
>             Fix For: 0.2.0
>         Attachments: GIRAPH-160.patch
> A very common format of graphs is adjacency lists with no values associated 
> to edges or vertices. For instance a line in the input can be of the type:
> 1 2 3
> which represents a vertex with id 1 that has edges to vertices 2 and 3 with 
> no values associated.
> I've created a vertex reader named AdjacencyListVertexReader which is 
> essentially a copy of the AdjacencyListVertexReader modified to handle this 
> format. It's an abstract class and subclasses can override the 
> defaultVertexValue() and defaultEdgeValue() methods to provide default values 
> for vertices and edges correspondingly (otherwise values are initialized to 
> null).
> I've also created an example subclass.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to