Jakob Homan commented on GIRAPH-182:

Hey Pradeep. Thanks for the contribution.
* Apache prohibits author tags to ensure that all the code is viewed as the 
whole community's responsiblity.
* SimpleSequenceFileVertexOutputFormat: We've thus far had the convention of 
using the type names in the in/outputformats. This is a bit verbose and may not 
be the right approach, but it's probably best to keep it in this patch.  Also 
can you provide javadoc for it?
* SequenceFileVertexOutputFormat: Any reason not to use the more standard M 
type variable? Some Javadoc for the class would be nice here too.
* Is it possible to add a unit test just to verify we get out from the file 
what we put in?

> Provide SequenceFileVertexOutputFormat as an available OutputFormat
> -------------------------------------------------------------------
>                 Key: GIRAPH-182
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-182
>             Project: Giraph
>          Issue Type: New Feature
>          Components: lib
>            Reporter: Pradeep Gollakota
>            Assignee: Pradeep Gollakota
>            Priority: Minor
>         Attachments: GIRAPH-182-1.patch
> SequenceFile's are heavily used in Hadoop. We should provide 
> SequenceFileVertexOutputFormat. Since SequenceFileVertexInputFormat is 
> already provided, it makes sense to also provide a mirroring OutputFormat

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to