Avery Ching commented on GIRAPH-185:

Thanks for looking at this Bo.  I have a couple of questions/comments.

1)  Do you have any idea what kind of performance gain there is?  Can you run a 
few experiments?

2)  The one downside is memory related.  By pre-allocating a list for every 
vertex, we are going to use memory, whether the vertex will receive a message 
or not.

I thought you might be looking into a higher level concurrency by using 
ConcurrentHashMap or something like that for transientInMessages?
> Improve concurrency of putMsg / putMsgList
> ------------------------------------------
>                 Key: GIRAPH-185
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-185
>             Project: Giraph
>          Issue Type: Improvement
>          Components: graph
>    Affects Versions: 0.2.0
>            Reporter: Bo Wang
>            Assignee: Bo Wang
>             Fix For: 0.2.0
>         Attachments: GIRAPH-185.patch
>   Original Estimate: 2h
>  Remaining Estimate: 2h
> Currently in putMsg / putMsgList, a synchronized closure is used to protect 
> the whole transientInMessages when adding the new message. This lock prevents 
> other concurrent calls to putMsg/putMsgList and increases the response time. 
> We should use fine-grain locks to allow high concurrency in message 
> communication.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to