-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5077/
-----------------------------------------------------------

Review request for giraph.


Summary
-------

All temporary files that the tests generate are now written to 
/tmp/_giraphTests including zooKeeper files, checkpoints etc. 

This behavior will be automatically configured whenever 
InternalVertexRunner.run() or BspCase.prepareJob() is used.

Usually I can't stop myself once I have my refactoring hat on, therefore I also 
tidied up a lot of minor stuff, removed code duplications etc.


This addresses bug GIRAPH-20.
    https://issues.apache.org/jira/browse/GIRAPH-20


Diffs
-----

  trunk/src/test/java/org/apache/giraph/TestZooKeeperExt.java 1332106 
  trunk/src/test/java/org/apache/giraph/graph/TestEdgeListVertex.java 1332106 
  trunk/src/test/java/org/apache/giraph/TestJsonBase64Format.java 1332106 
  trunk/src/test/java/org/apache/giraph/TestManualCheckpoint.java 1332106 
  trunk/src/test/java/org/apache/giraph/TestMutateGraphVertex.java 1332106 
  trunk/src/test/java/org/apache/giraph/TestNotEnoughMapTasks.java 1332106 
  trunk/src/test/java/org/apache/giraph/TestGraphPartitioner.java 1332106 
  trunk/src/test/java/org/apache/giraph/TestAutoCheckpoint.java 1332106 
  trunk/src/test/java/org/apache/giraph/TestBspBasic.java 1332106 
  trunk/src/test/java/org/apache/giraph/BspCase.java 1332106 
  trunk/src/main/java/org/apache/giraph/utils/InternalVertexRunner.java 1332106 
  trunk/src/main/java/org/apache/giraph/examples/SimplePageRankVertex.java 
1332106 
  trunk/src/main/java/org/apache/giraph/graph/GraphMapper.java 1332106 
  trunk/src/main/java/org/apache/giraph/graph/TextAggregatorWriter.java 1332106 
  trunk/src/main/java/org/apache/giraph/utils/FileUtils.java PRE-CREATION 

Diff: https://reviews.apache.org/r/5077/diff


Testing
-------

successfully passed local and pseudo-distributed tests with Hadoop 0.20.203


Thanks,

Sebastian

Reply via email to