On Tue, Oct 04, 2016 at 02:29:46PM -0700, Junio C Hamano wrote: > Jeff King <[email protected]> writes: > > > extern struct alternate_object_database { > > struct alternate_object_database *next; > > + > > char *name; > > - char base[FLEX_ARRAY]; /* more */ > > + char *scratch; > > + > > + char path[FLEX_ARRAY]; > > } *alt_odb_list; > > It is not wrong per-se, but I am a bit surprised to see that the > code keeps FLEX_ARRAY _and_ uses a separate malloc'ed area pointed > at by the scratch pointer.
Yeah, there's really no reason "path" could not become a non-flex buffer. I mostly left it there out of inertia. If you have a preference, I'm happy to change it. -Peff
