René Scharfe <[email protected]> writes:
> Would it make sense to mirror the previously existing condition and
> check for is_new instead? I.e.:
>
> if ((!patch->is_delete && !patch->new_name) ||
> (!patch->is_new && !patch->old_name)) {
>
Yes, probably.
> or
>
> if (!(patch->is_delete || patch->new_name) ||
> !(patch->is_new || patch->old_name)) {
This happens after calling parse_git_header() so we should know the
actual value of is_delete and is_new by now (instead of mistaking
-1 aka "unknown" as true), so this rewrite would also be OK.
