Re: [PATCH 11/12] grep: change the internal PCRE code & header names to be PCRE1

[Jeff King]

On Sat, Apr 08, 2017 at 01:25:05PM +0000, Ævar Arnfjörð Bjarmason wrote:

> diff --git a/builtin/grep.c b/builtin/grep.c
> index 9478ab5dff..dffb9743b8 100644
> --- a/builtin/grep.c
> +++ b/builtin/grep.c
> @@ -490,7 +490,7 @@ static void compile_submodule_options(const struct 
> grep_opt *opt,
>       case GREP_PATTERN_TYPE_FIXED:
>               argv_array_push(&submodule_options, "-F");
>               break;
> -     case GREP_PATTERN_TYPE_PCRE:
> +     case GREP_PATTERN_TYPE_PCRE1:
>               argv_array_push(&submodule_options, "-P");
>               break;

Hmm. This isn't a problem yet, but wouldn't this need to pass some
pcre1-specific option instead of just "-P"?

-Peff