On Tue, Nov 11, 2014 at 2:07 AM, Eric Sunshine <[email protected]> wrote: > On Mon, Nov 10, 2014 at 8:04 PM, Johan Herland <[email protected]> wrote: >> On Mon, Nov 10, 2014 at 9:42 PM, Junio C Hamano <[email protected]> wrote: >>> Johan Herland <[email protected]> writes: >>> >>>> Make this test script appear somewhat less old-fashioned: >>>> - Use test helper functions: >>>> - write_script >>>> - test_commit >>>> - test_write_lines >>>> - test_config >>>> - test_unconfig >>>> - test_path_is_missing >>>> - Remove whitespace between redirection operators and their targets. >>>> - Move preparation of "except" files into tests. >>> >>> expect, I think (no need to resend; I've fixed it up locally). >> >> Thanks. > > One further modernization would be to use the name "actual" rather > than "output" for files holding actual contents (as opposed to the > "expect" contents).
Agreed. Will be fixed in the re-roll. ...Johan -- Johan Herland, <[email protected]> www.herland.net -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
