On Tue, Apr 19, 2016 at 09:22:37AM -0700, Junio C Hamano wrote: > Johannes Schindelin <[email protected]> writes: > > > We simply need to read the config, is all. > > > > This fixes https://github.com/git-for-windows/git/issues/733 > > > > Signed-off-by: Johannes Schindelin <[email protected]> > > --- > > builtin/replace.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/builtin/replace.c b/builtin/replace.c > > index 748c6ca..02b13f6 100644 > > --- a/builtin/replace.c > > +++ b/builtin/replace.c > > @@ -475,6 +475,7 @@ int cmd_replace(int argc, const char **argv, const char > > *prefix) > > return replace_object(argv[0], argv[1], force); > > > > case MODE_EDIT: > > + git_config(git_default_config, NULL); > > if (argc != 1) > > usage_msg_opt("-e needs exactly one argument", > > git_replace_usage, options); > > The placement of git_config() makes me wonder why. > > I can understand "we only know edit mode needs config, and we know > it will never affect other modes to have the new call here", and it > would be good for an emergency patch for ancient maintenance track > that will not get any other changes or enhancements. I do not think > it is a sound reasoning to maintain the codefor the longer term, > though.
Yeah. I agree the patch here is not wrong, but I would prefer to just have git-replace load the config when it starts. It's _possible_ that something might break or misbehave, but IMHO any program which breaks when git_default_config() is run is probably in need of fixing. And I cannot recall any reason we did not read config when "--edit" was added; we just didn't think of it. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
