On Tue, May 10, 2016 at 5:11 PM, Junio C Hamano <[email protected]> wrote: > SZEDER Gábor <[email protected]> writes: >> I wonder if is it really necessary to specify the path to the .git >> directory via $GIT_DIR. Would 'git --git-dir=/over/there' be just as >> good? > > Then you are testing two different things that may go through > different codepaths. > > Adding yet another test to check "git --git-dir=" in addition is > fine, but that is not a replacement. We do want to make sure that > "GIT_DIR=there git" form keeps giving us the expected outcome.
When working on this, I did test with --git-dir= in place of GIT_DIR and some tests failed, but I didn't follow through to see what the actual problem was, partly because the code was in flux and I may have messed up something else, but primarily for the reason Junio gives above: I wanted this modernization series to be faithful to the original; additional testing can be added later. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
