On Wed, Jul 05, 2017 at 10:05:42AM -0600, Ken Dreyer wrote: > What do you think if we renamed the kwarg from "requires" to > "install_requires" ? Then the dependencies would automatically install > during "python setup.py install" in a virtualenv. > > I can't tell exactly what the plain "requires" kwarg does.
As far as I can tell "requires" looks for modules while install_requires looks for packages. So using install_requires would duplicate the code from requirements.txt. Isn't using requirements.txt the right thing? We have this since some time. Cheers, -- Guido > > > > On Tue, Jul 4, 2017 at 10:47 AM, Guido Günther <a...@sigxcpu.org> wrote: > > On Tue, Jul 04, 2017 at 06:23:50AM -0600, Ken Dreyer wrote: > >> On Tue, Jul 4, 2017 at 1:45 AM, Guido Günther <a...@sigxcpu.org> wrote: > >> > > >> > While the package is called python-dateutil the module is called > >> > dateutil. Fixed in master. > >> > >> Please accept my apologies for not testing this fully before sending! > >> > >> I wasn't familiar with the differences in setuptools' setup() > >> "requires" vs "install_requires" kwargs. > > > > No worries I should have tested better before pushing. > > -- Guido > _______________________________________________ git-buildpackage mailing list git-buildpackage@lists.sigxcpu.org http://lists.sigxcpu.org/mailman/listinfo/git-buildpackage