tree eea85c631b12c71ded1eaeb89d6c5816c13f38c3
parent bb6aacf75d559176d69cc32afcd0051f07d4ef03
author Alan Stern <[EMAIL PROTECTED]> Fri, 29 Jul 2005 18:03:17 -0400
committer Marcelo Tosatti <[EMAIL PROTECTED]> Sat, 06 Aug 2005 06:48:07 -0300

[PATCH] Revert USB UHCI changes

On Thu, 28 Jul 2005, Johannes Erdfelt wrote:

> Am I missing something here? We're certainly adding TDs to the schedule, so
> why is this patch setting the QH bit?

This is pretty embarrassing.  I didn't realize that the 2.4 driver uses
TDs to mark interrupt queues.  (2.6 uses QHs, which makes more sense.)
Of course, if I had done better testing the problem would have shown up
right away.

So please accept my apology, the UHCI part of that patch was completely
wrong.  Below is another patch to revert it.  The lesson is clear -- from
now on I'll leave the 2.4 driver alone!

Signed-off-by: Alan Stern <[EMAIL PROTECTED]>

 drivers/usb/host/uhci.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/host/uhci.c b/drivers/usb/host/uhci.c
--- a/drivers/usb/host/uhci.c
+++ b/drivers/usb/host/uhci.c
@@ -2924,7 +2924,7 @@ static int alloc_uhci(struct pci_dev *de
                /* Only place we don't use the frame list routines */
-               uhci->fl->frame[i] = uhci->skeltd[irq]->dma_handle | 
+               uhci->fl->frame[i] =  uhci->skeltd[irq]->dma_handle;
To unsubscribe from this list: send the line "unsubscribe git-commits-24" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to