tree 61110afaef5e8be41be940815a8bd6065e32c5da
parent 3462b925414a146d4c2252de97d20f89218d1ffb
author James Bottomley <[EMAIL PROTECTED]> Thu, 11 Aug 2005 01:29:15 -0700
committer Linus Torvalds <[EMAIL PROTECTED]> Thu, 11 Aug 2005 01:55:19 -0700

[PATCH] remove name length check in a workqueue

We have a chek in there to make sure that the name won't overflow
task_struct.comm[], but it's triggering for scsi with lots of HBAs, only
scsi is using single-threaded workqueues which don't append the "/%d"

All too hard.  Just kill the BUG_ON.

Cc: Ingo Molnar <[EMAIL PROTECTED]>
Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>

[ kthread_create() uses vsnprintf() and limits the thing, so no
  actual overflow can actually happen regardless ]

Signed-off-by: Linus Torvalds <[EMAIL PROTECTED]>

 kernel/workqueue.c |    2 --
 1 files changed, 2 deletions(-)

diff --git a/kernel/workqueue.c b/kernel/workqueue.c
--- a/kernel/workqueue.c
+++ b/kernel/workqueue.c
@@ -308,8 +308,6 @@ struct workqueue_struct *__create_workqu
        struct workqueue_struct *wq;
        struct task_struct *p;
-       BUG_ON(strlen(name) > 10);
        wq = kmalloc(sizeof(*wq), GFP_KERNEL);
        if (!wq)
                return NULL;
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to