tree d7db18d3d5f75fe4309ddc7aa373f3213f845b41
parent 40bb0c3ef52d872de348e10000eb5432a43a147d
author Paul Jackson <[EMAIL PROTECTED]> Wed, 24 Aug 2005 18:15:10 -0700
committer Linus Torvalds <[EMAIL PROTECTED]> Wed, 24 Aug 2005 23:40:45 -0700

[PATCH] cpu_exclusive sched domains build fix

As reported by Paul Mackerras <[EMAIL PROTECTED]>, the previous patch
"cpu_exclusive sched domains fix" broke the ppc64 build with
CONFIC_CPUSET, yielding error messages:

kernel/cpuset.c: In function 'update_cpu_domains':
kernel/cpuset.c:648: error: invalid lvalue in unary '&'
kernel/cpuset.c:648: error: invalid lvalue in unary '&'

On some arch's, the node_to_cpumask() is a function, returning
a cpumask_t.  But the for_each_cpu_mask() requires an lvalue mask.

The following patch fixes this build failure by making a copy
of the cpumask_t on the stack.

Signed-off-by: Paul Jackson <[EMAIL PROTECTED]>
Signed-off-by: Linus Torvalds <[EMAIL PROTECTED]>

 kernel/cpuset.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/kernel/cpuset.c b/kernel/cpuset.c
--- a/kernel/cpuset.c
+++ b/kernel/cpuset.c
@@ -645,7 +645,9 @@ static void update_cpu_domains(struct cp
                int i, j;
                for_each_cpu_mask(i, cur->cpus_allowed) {
-                       for_each_cpu_mask(j, node_to_cpumask(cpu_to_node(i))) {
+                       cpumask_t mask = node_to_cpumask(cpu_to_node(i));
+                       for_each_cpu_mask(j, mask) {
                                if (!cpu_isset(j, cur->cpus_allowed))
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to