tree 090a6020ec9c9c4e91615465b54e29084244d9f7
parent 84a2ea1c2cee0288f96e0c6aa4f975d4d26508c7
author Ralf Baechle <[EMAIL PROTECTED]> Wed, 24 Aug 2005 18:01:33 +0100
committer Jeff Garzik <[EMAIL PROTECTED]> Sat, 27 Aug 2005 12:32:39 -0400

[PATCH] Fix 6pack setting of MAC address

Don't check type of sax25_family; dev_set_mac_address has already done
that before and anyway, the type to check against would have been
ARPHRD_AX25.  We only got away because AF_AX25 and ARPHRD_AX25 both happen
to be defined to the same value.

Don't check sax25_ndigis either; it's value is insignificant for the
purpose of setting the MAC address and the check has shown to break
some application software for no good reason.

Signed-off-by: Ralf Baechle DL5RB <[EMAIL PROTECTED]>
Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]>

 drivers/net/hamradio/6pack.c |    6 ------
 1 files changed, 6 deletions(-)

diff --git a/drivers/net/hamradio/6pack.c b/drivers/net/hamradio/6pack.c
--- a/drivers/net/hamradio/6pack.c
+++ b/drivers/net/hamradio/6pack.c
@@ -308,12 +308,6 @@ static int sp_set_mac_address(struct net
        struct sockaddr_ax25 *sa = addr;
-       if (sa->sax25_family != AF_AX25)
-               return -EINVAL;
-       if (!sa->sax25_ndigis)
-               return -EINVAL;
        memcpy(dev->dev_addr, &sa->sax25_call, AX25_ADDR_LEN);
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to